Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix googlenet test case for pyt2.5 #214

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix googlenet test case for pyt2.5 #214

merged 1 commit into from
Nov 14, 2024

Conversation

shivadbhavsar
Copy link
Collaborator

Somehow in the new torchvision version, the behavior of loading googlenet is different when no weights are specified (leads to segfaults when compiling via migraphx, not sure why but that can be a different issue to look at). Works as expected once pretrained weights are specified.

The tracer change is because the GoogLeNet model is loaded with empty modules (see below snippet):

   (branch4): Sequential(
      (0): MaxPool2d(kernel_size=3, stride=1, padding=1, dilation=1, ceil_mode=True)
      (1): BasicConv2d(
        (conv): Conv2d(832, 128, kernel_size=(1, 1), stride=(1, 1), bias=False)
        (bn): BatchNorm2d(128, eps=0.001, momentum=0.1, affine=True, track_running_stats=True)
      )
    )
  )
  (aux1): None
  (aux2): None
  (avgpool): AdaptiveAvgPool2d(output_size=(1, 1))

In this case those modules need to be skipped by the tracer (not sure why they exist all of a sudden in the new version).

@shivadbhavsar shivadbhavsar self-assigned this Nov 14, 2024
@shivadbhavsar shivadbhavsar added the bugfix Fixing existing functionality label Nov 14, 2024
@shivadbhavsar
Copy link
Collaborator Author

CI passed but hit rate limit:

[GitStatusWrapper] - Setting SUCCESS status for Jenkins - pytest-Any on commit 916db4df68f534ddfbb9ac33486043f23f1f80f9

... 

hudson.remoting.ProxyException: API rate limit reached

force merging

@shivadbhavsar shivadbhavsar merged commit 75fdc3e into master Nov 14, 2024
3 of 6 checks passed
@shivadbhavsar shivadbhavsar deleted the googlenet_fix branch November 14, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants